Rollup of 12 pull requests #148624
Merged
Rollup of 12 pull requests #148624
+528
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use binary literals instead of hex literals.
This caused Emacs to throw errors when opening files. Introduced in 3fe3edb.
Offload device LLVM's offload functionality usually expects an extra dyn_ptr argument. We could avoid it,b ut likely gonna need it very soon in one of the follow-up PRs (e.g. to request shared memory). So we might as well already add it. This PR adds a %dyn_ptr ptr to GPUKernel ABI functions, if the offload feature is enabled. WIP r? ```@ghost```
…op_if, r=Amanieu Stabilize `vec_deque_pop_if` Tracking issue: rust-lang#135889 Closes rust-lang#135889 Also fixes a typo mentioned in rust-lang#135889 (comment) FCP: rust-lang#135889 (comment) `@rustbot` label -T-libs +T-libs-api +needs-fcp +S-waiting-on-fcp r? t-libs-api
Early return if span is from expansion so we dont get empty span and ice later on Fixes rust-lang#147255 The problem original was from that stmt.span was from expansion and it span was bigger than right part which is block.span, so it causes empty span and panic later on, I decided to add checks for both of them to be on the safe side r? `@fmease` (you were in discussion on this issue so I decided to assign you, feel free to reroll)
btree: cleanup difference, intersection, is_subset
…one-doctests, r=tgross35 style: Use binary literals instead of hex literals in doctests for `highest_one` and `lowest_one` For example, I think it's easier to understand that the index of the highest bit set to one in `16` is `4` as `0b10000` than as `0x10`. ```rust assert_eq!(0x10_u64.highest_one(), Some(4)); ``` Instead of: ```rust assert_eq!(0b10000_u64.highest_one(), Some(4)); ``` rust-lang#145203
…r=Kivooeo Add typo suggestion for a misspelt Cargo environment variable Fixes rust-lang#148439
…rect-precedence, r=hkBst,Kivooeo Fix incorrect precedence caused by range expression Fixes rust-lang#148344 The testcase `tests/ui/feature-gates/feature-gate-new_range` is also fixed.
…henyukang Fix mismatched brackets in generated .dir-locals.el This caused Emacs to throw errors when opening files. Introduced in 3fe3edb.
…adme-link, r=chenyukang fix dev guide link in rustc_query_system/dep_graph/README.md
…c-from-mut-slice, r=m-ou-se core docs: add notes about availability of `Atomic*::from_mut_slice` See rust-lang#76314 (comment) r? libs-api
…=pietroalbini Backport 1.91.1 relnotes to main Backport of the release notes from rust-lang#148593 to the main branch. This should land before Monday so that the automation creates the GitHub release.
…yukang
Sync str::rsplit_once example with str::split_once
This adds `"cfg=".rsplit_once('=')` case to `rsplit_once` example, bringing it in sync with example for `split_once`. For consistency and to make life easier for ones who want to ensure bahaviour of this specific edge case.
rustbot
added
A-LLVM
rustbot
added
T-release
Member
Author
|
@bors r+ rollup=never p=5 |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing c90bcb9 (parent) -> 0bbef55 (this PR) Test differencesShow 1886 test diffsStage 0
Stage 1
Stage 2
(and 44 additional test diffs) Additionally, 1742 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 0bbef557bb02e6fda8fde2c2cf9c59ee55ca40e9 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
Collaborator
|
📌 Perf builds for each rolled up PR:
previous master: c90bcb9571 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Collaborator
|
Finished benchmarking commit (0bbef55): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.8%, secondary 0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary -2.6%, secondary -2.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary -0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.185s -> 475.138s (-0.01%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
vec_deque_pop_if#145992 (Stabilizevec_deque_pop_if)highest_oneandlowest_one#148520 (style: Use binary literals instead of hex literals in doctests forhighest_oneandlowest_one)Atomic*::from_mut_slice#148578 (core docs: add notes about availability ofAtomic*::from_mut_slice)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup